fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #8487 from nextcloud/backport/8486/stable-3.16

[stable-3.16] perf(activitylistmodel): store conflicts in a separate list

perf(activitylistmodel): store conflicts in separate list

Figuring out whether a sync conflict occurred by iterating through the
entire activity list each time a new activity was added is really slow,
even more so when there already are thousands of previous activities.
This was especially noticeable during complete initial full syncs
involving more than ~5000 files.

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>

perf(activitylistmodel): avoid creation of temporary Activity objects

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>

Merge pull request #8484 from nextcloud/backport/8450/stable-3.16

[stable-3.16] fix: implicit hydration will not abort synchronization

fix: implicit hydration will not abort synchronization

should avoid constant sync/abort loop for people having many files

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Merge pull request #8485 from nextcloud/backport/8456/stable-3.16

[stable-3.16] fix: do not recurse inside a remote folder when etag did not change

fix: do not recurse inside a remote folder when etag did not change

we do not want to remote discover a folder just because the permissions
are modified but not the etag

for any valid case, etag must change

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

feat: test to ensure etag constant means no PROPFIND on a folder

should help ensure we send a PROPFIND only when the folder etag changes

if some metadata apparently change, this is not enough to send a
PROPFIND request

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #8476 from nextcloud/backport/8475/stable-3.16

[stable-3.16] ci: change download url of appimagetool

ci: change download url of appimagetool

The appimagetool as previously provided from the AppImageKit repo was
deprecated and removed.

The new versions as provided by the appimagetool repository also ship
with an updated runtime which from my understanding improve
compatibility (e.g. libfuse is now statically linked, so systems don't
need to have it present) and seem to slightly reduce the binary size as
well.

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #8473 from nextcloud/backport/8452/stable-3.16

[stable-3.16] Remove Ubuntu Oracular, add Questing

ci: Remove Ubuntu Oracular, add Questing

Signed-off-by: István Váradi <ivaradi@varadiistvan.hu>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #8459 from nextcloud/backport/8455/stable-3.16

[stable-3.16] ci: switch back to upstream CraftMaster

ci: switch back to upstream CraftMaster

The fix we needed was merged this week 🎉
https://invent.kde.org/packaging/craftmaster/-/merge_requests/7

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(logs): remove not so useful logs

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

fix(logs): remove useless logs

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

chore: prepare for 3.16.6 release

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Merge pull request #8382 from nextcloud/backport/8370/stable-3.16

[stable-3.16] fix(readonly): better handling of ACL on read-only files on windows

fix(readonly): better handling of ACL on read-only files on windows

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Merge pull request #8381 from nextcloud/backport/8356/stable-3.16

[stable-3.16] fix(crash): debug builds would not try to remove a not found job

fix(crash): debug builds would not try to remove a not found job

in release builds we would happily try to remove an element from QList
with invalid index (-1) if the job is not found

avoid doing this in release builds and keep teh assert in debug builds

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Merge pull request #8380 from nextcloud/backport/8379/stable-3.16

[stable-3.16] fix(accountmanager): use defaults from configFile if setting was not present

style: access static members through `::`

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>

fix(accountmanager): use defaults from configFile if setting was not present

This prevented e.g. "launchOnSystemStartup" to be set on a fresh
installation.

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #8378 from nextcloud/backport/8375/stable-3.16

[stable-3.16] fix(activitylistmodel): fix activities for e2ee files

fix(activitylistmodel): fix activities for e2ee files

the sharing/activity button was supposed to be hidden, but a later
change forgot to adapt the variable used for querying the file metadata
so it never could determine the e2e-status

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #8348 from nextcloud/backport/8347/stable-3.16

[stable-3.16] fix(msi): set the REBOOT property in the MSI

fix(msi): set the REBOOT property in the MSI

A value of `ReallySuppress` will not display a reboot prompt whenever
the `ForceReboot` action was run, or whenever a reboot was scheduled
(e.g. by `FilesInUse`).  Apparently this will not reboot the machine on
its own either.

`winget` sets this property in its manifest[0], and according to reports in
issue #5369 this seems to work.

See also: https://learn.microsoft.com/en-us/windows/win32/msi/reboot

[0]: https://github.com/microsoft/winget-pkgs/blob/0b40904d1480f67d48c6d8e2ac7f27b31aa566c7/manifests/n/Nextcloud/NextcloudDesktop/3.16.5/Nextcloud.NextcloudDesktop.installer.yaml#L16

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>

Merge pull request #8346 from nextcloud/backport/8220/stable-3.16

[stable-3.16] fix(macOS): Fix prompting of user for permission to access "other" apps' data

feat(mac-crafter): Use our default entitlements file during default mac-crafter build run

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

feat(macOS): Add entitlements file

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

feat(mac-crafter): Add entitlements path option to codesign command

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

feat(mac-crafter): Add ability to codesign with an entitlements file

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

chore: prepare for release 3.16.4

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>

Merge pull request #8332 from nextcloud/backport/8330/stable-3.16

[stable-3.16] fix(lockfilejobs): ensure using correct file path

fix(lockfilejobs): ensure using correct file path

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>

Merge pull request #8328 from nextcloud/backport/8290/stable-3.16

[stable-3.16] fix(filesystem): only change folder permissions if required

fix(propagator): touch folder paths if permissions changed

Extra safeguard to ensure that the usage of
`FileSystem::setFolderPermissions` won't start a new sync run if
FolderWatcher/inotify detects a change in the file metadata...

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>

fix(filesystem): only change folder permissions if required

On Linux changing the permissions causes inotify to create a IN_ATTRIB
event -- even if the permissions stays the same.

Such an event is passed to the filesystem watcher which lets the client
schedule a new sync run.  In certain conditions, this could happen
during every sync run...

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>

Merge pull request #8327 from nextcloud/backport/8297/stable-3.16

[stable-3.16] fix(permissions): handle properly CanRead permission from server

fix(permissions): handle properly CanRead permission from server

if Readable permissions is missing, do nto try to download the file

if a file was downlaoded but Readable permission is now missing, remove
it

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Merge pull request #8326 from nextcloud/backport/8246/stable-3.16

[stable-3.16] fix(readonly): use native separator in paths before calling windows API

fix(readonly): use native separator in paths before calling windows API

we need platform native separators for file paths that will be used in
native Windows platform specific APIs

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Merge pull request #8322 from nextcloud/backport/8321/stable-3.16

[stable-3.16] Bugfix/windows regressions

fix(windows): when deleting a file use safe long windows path

will avoid getting a content access denied error because some paths is
too long for windows default limit and has to use the special syntax for
long path

see https://learn.microsoft.com/en-us/windows/win32/fileio/maximum-file-path-limitation?tabs=registry

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

fix(readonly): avoid changing permissions when not needed

in FilePermissionsRestore, first checks the folder permissions before
changing them

will avoid useless call changing permissions when not needed

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

fix(readonly): avoid implicit hydration when modifying permissions

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Merge pull request #8325 from nextcloud/backport/8243/stable-3.16

[stable-3.16] fix(readonly): apply ACL also to files inside read-only folders

fix(readonly): apply ACL also to files inside read-only folders

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Merge pull request #8324 from nextcloud/backport/8241/stable-3.16

[stable-3.16] fix(readonly): enable MOVE rollback when folder is read-only

fix(readonly): enable MOVE rollback when folder is read-only

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Merge pull request #8323 from nextcloud/backport/8240/stable-3.16

[stable-3.16] fix(rename): avoid failing hard when rename is rejected by server

fix(rename): avoid failing hard when rename is rejected by server

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

feat(windows): use cmake to configure windows integration DLL version

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Merge pull request #8316 from nextcloud/backport/8277/stable-3.16

[stable-3.16] feat(mac-crafter): retry code-signing attempts

feat(mac-crafter): retry code-signing attempts

This step sometimes fails with an error such as: "A timestamp was
expected but was not found.".  Any code-signing errors will result in
the notarisation step to fail.

Apparently this might be due to intermittent network issues.  Let's just
retry codesigning a couple of times in the case it fails ...

See also: https://developer.apple.com/documentation/security/resolving-common-notarization-issues#Include-a-secure-timestamp

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>

Merge pull request #8317 from nextcloud/backport/8217/stable-3.16

[stable-3.16] fix(appimage): move VFS plugins to AppDir

fix(appimage): move VFS plugins to AppDir

This allows the AppImage build to find and load the experimental VFS
plugins, and not crash with:

    [ critical plugins /home/user/src/common/vfs.cpp:250 ]: Could not load plugin: not existent or bad metadata "nextclouddevsync_vfs_suffix"
    [ fatal default /home/user/src/gui/folderman.cpp:326 ]: Could not load plugin
    [1]    72936 IOT instruction (core dumped)  ./nextclouddev-master-x86_64.AppImage

Fixes #7135
Fixes #7194
Fixes #7465

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>

Merge pull request #8315 from nextcloud/backport/8178/stable-3.16

[stable-3.16] Bugfix/version windows integration improve install